Code Review for illumos-gate

Prepared by:Alexander Pyhalov on 2019-Mar-07 17:41 +0300 MSK
Workspace:/export/home/alp/srcs/illumos-gate (at 93f678c6ad8f)
Compare against: /export/home/alp/srcs/illumos-gate (explicit revision 96cf04672307)
Summary of changes: 830 lines changed: 364 ins; 425 del; 41 mod; 2721 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/chgrp/Makefile

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
21 lines changed: 1 ins; 13 del; 7 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/chgrp/chgrp.c

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
32 lines changed: 7 ins; 25 del; 0 mod; 534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/chown/Makefile

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
22 lines changed: 1 ins; 14 del; 7 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/chown/chown.c

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
33 lines changed: 7 ins; 25 del; 1 mod; 518 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ksh/builtins/alias.c

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
4 lines changed: 0 ins; 2 del; 2 mod; 257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libshell/common/data/solaris_cmdlist.h

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
1 line changed: 0 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/chgrp.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
68 lines changed: 10 ins; 50 del; 8 mod; 302 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/chown.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
312 lines changed: 4 ins; 294 del; 14 mod; 304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-utiltest.mf

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
13 lines changed: 13 ins; 0 del; 0 mod; 344 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-xopen-xcu4.mf

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
4 lines changed: 2 ins; 2 del; 0 mod; 108 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/runfiles/default.run

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
1 line changed: 1 ins; 0 del; 0 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/Makefile

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
1 line changed: 0 ins; 0 del; 1 mod; 21 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/Makefile

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/chown_test.ksh

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/Makefile

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout0

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout1

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout10

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout11

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout12

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout2

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout3

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout4

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout5

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout6

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout7

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout8

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/chown/files/cout9

10417 recursive chown should not traverse any symbolic links by default
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Peter Tribble <peter.tribble@gmail.com>
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.